[Mesa-dev] [PATCH] src/egl/Makefile: fix build race

[Eric Engestrom]

On Thursday, 2018-06-28 23:01:59 +0100, Ross Burton wrote:
> There is a parallel make build issue in src/egl/drivers/dri2/
> for wayland builds. Can be reproduced with:
> 
> $ rm src/egl/drivers/dri2/*.h src/egl/drivers/dri2/platform_wayland.lo
> $ make -C src/egl/ drivers/dri2/platform_wayland.lo
> ../../../mesa-18.1.2/src/egl/drivers/dri2/platform_wayland.c:50:10: fatal error: linux-dmabuf-unstable-v1-client-protocol.h: No such file or directory
> 
> This patch adds the missing dependency.

I remember seeing this error from time to time, but I never looked into it;
thanks for tracking it down to its source!

Fixes: 02cc359372773800de817 "egl/wayland: Use linux-dmabuf interface for buffers"
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

Changed the title to "egl: fix build race in automake" to follow the
convention, and pushed :)

> ---
>  src/egl/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am
> index be3547d968..1a2273b8c3 100644
> --- a/src/egl/Makefile.am
> +++ b/src/egl/Makefile.am
> @@ -80,6 +80,7 @@ drivers/dri2/linux-dmabuf-unstable-v1-client-protocol.h: $(WL_DMABUF_XML)
>  if HAVE_PLATFORM_WAYLAND
>  drivers/dri2/linux-dmabuf-unstable-v1-protocol.lo: drivers/dri2/linux-dmabuf-unstable-v1-client-protocol.h
>  drivers/dri2/egl_dri2.lo: drivers/dri2/linux-dmabuf-unstable-v1-client-protocol.h
> +drivers/dri2/platform_wayland.lo: drivers/dri2/linux-dmabuf-unstable-v1-client-protocol.h
>  
>  AM_CFLAGS += $(WAYLAND_CLIENT_CFLAGS)
>  libEGL_common_la_LIBADD += $(WAYLAND_CLIENT_LIBS)
> -- 
> 2.11.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev