[Mesa-dev] [PATCH v2 0/2] r600: Fix array texture slice index evaluation

Gert Wollny gert.wollny at collabora.com
Fri Jun 29 14:35:35 UTC 2018


I reworded parts of the comments, and simplified the patch against the shader
to correct the piglit failures and taking into account that a shader can not
set an offset for the array index at all.

Apart from the dEQP tests I've run
  ./piglit run gpu -t texture 
with no changes. (I always got hangs with "./piglit run gpu -x atomicity",
with or without these patches, some image_store_load tests seem to behave badly)

I'm still thinking about how relevant the TRUNC versus default rounding mode is
and what is actually the more correct approach for point sampling. That's also why I
think that it is better to keep the patches apart, to better be able to biscet possible
issues.

best,
Gert

Gert Wollny (2):
  r600: correct texture offset for array index lookup
  r600: set rounding mode for texture array layer selection

 src/gallium/drivers/r600/evergreen_state.c | 22 ++++++++++++++++++++++
 src/gallium/drivers/r600/r600_shader.c     | 18 +++++++++++++++++-
 2 files changed, 39 insertions(+), 1 deletion(-)

-- 
2.16.4



More information about the mesa-dev mailing list