[Mesa-dev] [PATCH v2 3/3] st/mesa: Also check for PIPE_FORMAT_A8R8G8B8_SRGB for texture_sRGB

Marek Olšák maraeo at gmail.com
Fri Jun 29 21:12:03 UTC 2018


For the series:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Fri, Jun 22, 2018 at 9:59 AM, Tomeu Vizoso
<tomeu.vizoso at collabora.com> wrote:
> and PIPE_FORMAT_R8G8B8A8_SRGB, as well.
>
> The reason for this is that when Virgl runs with GLES on the host, it
> cannot directly upload textures in BGRA.
>
> So to avoid a conversion step, consider the RGB sRGB formats as well for
> this extension.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> ---
>  src/mesa/state_tracker/st_extensions.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
> index 274df7bd6a6a..ba0f671c363d 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -811,7 +811,9 @@ void st_init_extensions(struct pipe_screen *screen,
>        { { o(EXT_texture_sRGB),
>            o(EXT_texture_sRGB_decode) },
>          { PIPE_FORMAT_A8B8G8R8_SRGB,
> -          PIPE_FORMAT_B8G8R8A8_SRGB },
> +          PIPE_FORMAT_B8G8R8A8_SRGB,
> +          PIPE_FORMAT_A8R8G8B8_SRGB,
> +          PIPE_FORMAT_R8G8B8A8_SRGB},
>          GL_TRUE }, /* at least one format must be supported */
>
>        { { o(EXT_texture_type_2_10_10_10_REV) },
> --
> 2.17.0
>


More information about the mesa-dev mailing list