[Mesa-dev] [PATCH] nv50/ir: handle clipvertex for geometry shaders as well

Ilia Mirkin imirkin at alum.mit.edu
Sat Jun 30 19:30:18 UTC 2018


Tes too, right? Also does the logic that forces recompiles work ok? I seem
to recall it was tied to vs.

On Sat, Jun 30, 2018, 10:18 Karol Herbst <kherbst at redhat.com> wrote:

> this will be needed for compatibility profiles
>
> Signed-off-by: Karol Herbst <kherbst at redhat.com>
> ---
>  src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> index c92acc996c4..1151e0ee255 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> @@ -3613,6 +3613,9 @@ Converter::handleInstruction(const struct
> tgsi_full_instruction *insn)
>                                    info->out[info->io.viewportId].slot[0]
> * 4);
>           mkStore(OP_EXPORT, TYPE_U32, vpSym, NULL, viewport);
>        }
> +      /* handle user clip planes for each emitted vertex */
> +      if (info->io.genUserClip > 0)
> +         handleUserClipPlanes();
>        /* fallthrough */
>     case TGSI_OPCODE_ENDPRIM:
>     {
> @@ -3787,7 +3790,7 @@ Converter::handleInstruction(const struct
> tgsi_full_instruction *insn)
>        setPosition(epilogue, true);
>        if (prog->getType() == Program::TYPE_FRAGMENT)
>           exportOutputs();
> -      if (info->io.genUserClip > 0)
> +      if (prog->getType() == Program::TYPE_VERTEX && info->io.genUserClip
> > 0)
>           handleUserClipPlanes();
>        mkOp(OP_EXIT, TYPE_NONE, NULL)->terminator = 1;
>     }
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180630/394fadc7/attachment.html>


More information about the mesa-dev mailing list