[Mesa-dev] [RFC PATCH] get_reviewer.pl: Delete

[Eric Anholt]

Rob Clark <robdclark at gmail.com> writes:

> On Wed, Feb 28, 2018 at 4:09 PM, Eric Anholt <eric at anholt.net> wrote:
>> Matt Turner <mattst88 at gmail.com> writes:
>>
>>> I find this script *really* annoying. Getting Cc'd on a random sample of
>>> a series is doing it wrong. Cc lists of 14 people is doing it wrong.
>>>
>>> Let's start the negotiation with "delete this script" and see if anyone
>>> can come up with a way of making this not so stupid.
>>
>> Patch submission done well IMO would be something like github PRs, with
>> a bot that auto-tags people based on a MAINTAINERS-style opt-in for
>> reviewing certain paths within the tree.
>>
>> I don't think get_reviewers.pl improves the git-send-email situation
>> compared to maintainers needing to manage email filters.  It's not
>> consistent, so you need to indoctrinate new submitters (more barriers to
>> entry!) and maintainers need to maintain their mail filters anyway.
>
> Hmm, you have mail filters that parse paths in git patches?

No, I actually skim all the patches.  But it's what you'd have to do if
you want to actually see all patches to your area and not actually skim
all the patches yourself, since get_reviewer.pl isn't (and won't ever
be) used universally.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180228/e964ba69/attachment.sig>