[Mesa-dev] [PATCH 1/2] i965: Generalize intel_upload.c to support multiple uploaders.

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 2 09:00:37 UTC 2018


Quoting Kenneth Graunke (2018-03-02 08:44:56)
> On Thursday, March 1, 2018 4:16:13 PM PST Chris Wilson wrote:
> > Quoting Kenneth Graunke (2018-03-01 23:39:54)
> > > I'd like to reuse the upload logic for a new program cache, but the
> > > buffers will need to have a different lifetime than the default
> > > uploader, and also some address space restrictions.
> > > 
> > > This makes it a bit more like u_upload_mgr.
> > 
> > To be clear, this patch is just prep work that should be no functional
> > changes? To my tired eyes, it should be the same code with a different
> > lick of paint, but it would be nice to know if I missed something.
> > -Chris
> 
> Correct - it basically makes things take a uploader struct instead of
> always referring to brw->upload, so you can have more than one of them
> if you like.
> 
> It works exactly the same other than that.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the mesa-dev mailing list