[Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

Stefan Dirsch sndirsch at suse.de
Fri Mar 2 10:49:37 UTC 2018


On Thu, Mar 01, 2018 at 09:00:38AM -0800, Dylan Baker wrote:
> Quoting sndirsch at suse.de (2018-03-01 08:11:54)
> > From: Stefan Dirsch <sndirsch at suse.de>
> > 
> > Patch by "Tomas Chvatal" <tchvatal at suse.com> with modifications
> > by "Michal Srb" <msrb at suse.com> to not break python 2.
> > 
> > https://bugzilla.suse.com/show_bug.cgi?id=1082303
> > 
> > v2:
> > - no longer try to encode a unicode
> > - make use of 'from __future__ import print_function', so semantics
> >   of print statements in python2 are closer to print functions in python3
> > 
> > https://lists.freedesktop.org/archives/mesa-dev/2018-February/187056.html
> > 
> > Signed-off-by: Stefan Dirsch <sndirsch at suse.de>
> > Reviewed-by: Tomas Chvatal <tchvatal at suse.com>
> > Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
> 
> Process comment for you. Reviewed-by in mesa is like the kernel, it carries a
> very specific formal meaning and you don't add Reviewed-by (or Acked-by,
> Tested-by, etc) unless someone explicitly says that they give a Reviewed-by.

This has been a mistake. I apologize.

> Also, please use the natural name at domain form for emails. Scripts that
> scrape emails out of emails and git commits are not fooled by "name at
> domain" anyway.

Yeah. I believe I copied the header from the mesa-devel mail archive. Then I
was running out of time when sending the email, etc. Sigh.

I've sent the patch once more to the mailing list.

> Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Thanks!

Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
---------------------------------------------------------------
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---------------------------------------------------------------


More information about the mesa-dev mailing list