[Mesa-dev] [PATCH] radeon/vcn: use enc profile instead of pic profile

[Leo Liu]

On 03/01/2018 02:30 PM, Boyuan Zhang wrote:
> Agree, I added the missing profile and entry_point to st/omx.
> Please see the attached patch below.
>
> On radeon driver side, do you think we should still check the profile
> in encoder instead since profile shouldn't been changed during encoding.
> Or we can just leave it with picture profile with this fix?
>
> From: Boyuan Zhang <boyuan.zhang at amd.com>
>
> Profile and entry point were missing in the picture structure.
> Therefore, add them back.
>
> Signed-off-by: Boyuan Zhang <boyuan.zhang at amd.com>
Please rename the patch subject to st/omx_bellagio, add Cc tag, and resend.
With that, the patch is
Reviewed-by: Leo Liu <leo.liu at amd.com>

> ---
>  src/gallium/state_trackers/omx_bellagio/vid_enc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/state_trackers/omx_bellagio/vid_enc.c 
> b/src/gallium/state_trackers/omx_bellagio/vid_enc.c
> index 1a4fb62..162ec1f 100644
> --- a/src/gallium/state_trackers/omx_bellagio/vid_enc.c
> +++ b/src/gallium/state_trackers/omx_bellagio/vid_enc.c
> @@ -1098,6 +1098,8 @@ static void enc_HandleTask(omx_base_PortType 
> *port, struct encode_task *task,
>
>     picture.picture_type = picture_type;
>     picture.pic_order_cnt = task->pic_order_cnt;
> +   picture.base.profile = 
> enc_TranslateOMXProfileToPipe(priv->profile_level.eProfile);
> +   picture.base.entry_point = PIPE_VIDEO_ENTRYPOINT_ENCODE;
>     if (priv->restricted_b_frames && picture_type == 
> PIPE_H264_ENC_PICTURE_TYPE_B)
>        picture.not_referenced = true;
>     enc_ControlPicture(port, &picture);