[Mesa-dev] [PATCH 1/2] clover: Allow overriding platform/device version numbers

[Francisco Jerez]

Emil Velikov <emil.l.velikov at gmail.com> writes:

> Hi Aaron,
>
> On 1 March 2018 at 19:44, Aaron Watry <awatry at gmail.com> wrote:
>> Useful for testing API, builtin library, and device completeness of
>> not-yet-supported versions.
>>
> Small fly-by comment:
>
> As-is it seems like getenv(foo) will be called multiple times.
> Perhaps it isn't that 'slow' since it's not a hot path.
>
> Yet again, one could get different version across calls which does sound icky.
>
> Perhaps it's not worth bothering about?

These are far from hot paths...  But if you care a trivial solution
would be to mark version_string and friends as static const, so the
initializer is only evaluated once.

> Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180302/b3ea6eef/attachment.sig>