[Mesa-dev] [PATCH] vbo: Try to reuse the same VAO more often for successive dlists.

[Mathias Fröhlich]

Hi Brian,

On Friday, 2 March 2018 16:12:04 CET Brian Paul wrote:
> I'll try to re-check the dlist application later.  For now though, this 
> patch looks good.  One thing below...

Thanks for the review!


> > +   assert(old_offset <= buffer_offset);
> > +   const GLintptr offset_diff = buffer_offset - old_offset;
> >      GLuint start_offset = 0;
> > -   if (0 < buffer_offset && 0 < stride && buffer_offset % stride == 0) {
> > +   if (0 < offset_diff && 0 < stride && offset_diff % stride == 0) {
> 
> Minor nit: I find offset_diff > 0 && stride > 0 to be a little easier to 
> read.

I usually think in terms of the number line so for me my variant was more 
intuitive. But I am not the only reader!

Changed to your variant!
And pushed!

best

Mathias