[Mesa-dev] [PATCH v2] mesa: add glsl version query (v4)

[Brian Paul]

On 03/05/2018 06:14 AM, Emil Velikov wrote:
> On 13 February 2018 at 20:27, Brian Paul <brianp at vmware.com> wrote:
> 
>> On 02/13/2018 11:10 AM, Vadym Shovkoplias wrote:
>>>
>>> Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS
>>> and glGetStringi for GL_SHADING_LANGUAGE_VERSION
>>>
>>> v2:
>>>     - Combine similar functionality into
>>>       _mesa_get_shading_language_version() function.
>>>     - Change GLSL version return mechanism.
>>> v3:
>>>     - Add return of empty string for GLSL ver 1.10.
>>>     - Move _mesa_get_shading_language_version() function
>>>       to src/mesa/main/version.c.
>>> v4:
>>>     - Add OpenGL version check.
>>>
>>> Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D104915&d=DwIBaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA&m=9Bvlnmqk3Jn_8FGEjuvIGvzsb-XfXR1QD83xzgX4mAw&s=H2WyZqCoRkMR_0L9_GX1EMoT6344LHbHPdrGF0S2Sts&e=
>>> Signed-off-by: Andriy Khulap <andriy.khulap at globallogic.com>
>>> Signed-off-by: Vadym Shovkoplias <vadym.shovkoplias at globallogic.com>
> Brian, Vadym,
> 
> Seems like we'd want this for the stable branches right?
> The bug report does not mention any specific program that depends on
> this fix, yet it's a worth have IMHO.
> 
> Do let me know if you think that's a bad idea.

Fine by me.  I think the patch should apply cleanly.

-Brian