[Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}

[Brian Paul]

On 03/05/2018 01:29 PM, Ian Romanick wrote:
> On 03/05/2018 11:08 AM, Ian Romanick wrote:
>> On 03/05/2018 10:48 AM, Emil Velikov wrote:
>>> Hi all,
>>>
>>> It seems like these two extensions were never implemented or advertised.
>>> Be that in:
>>>   - glx/dri
>>>   - glx/apple
>>>   - classic xlib-glx
>>>   - gallium xlib-glx
>>>
>>> Yet, the entry points were available, hence apps might have linked
>>> against it.
>>
>> If an app was linking with an extension entry point instead of using
>> glXGetProcAddress, it is the app's bug.

True, but if we remove it and an app starts failing the end-user just 
thinks "broken driver" and gets frustrated.  I seem to remember writing 
some GLX stubs years ago for that reason.


>>
>>> Furthermore I cannot see any users of those on my system and a courtesy
>>> google search. Additionally the Nvidia driver (checked version 390.25)
>>> does not implement/advertise them either.
>>>
>>> That said, I'm fairly confident that we can safely remove the no-op
>>> stubs. Even though that the entry points were statically exposed.
>>>
>>> Brian, Ian,
>>>
>>> Do you have any recollection about these experimental SGI extensions?
>>
>> Ajax and I had talked about implementing swap_group a few times, but
>> there were some technical challenges that we were too lazy to tackle.  I
>> think that's about as far as any of it ever got.
> 
> I should have also said...
> 
> Acked-by: Ian Romanick <ian.d.romanick at intel.com>

I'm fine with removing them too.  If someone really complains, they can 
always be restored.

Acked-by: Brian Paul <brianp at vmware.com>


> 
>>> Thanks
>>> Emil
>>>
>>> Cc: Ian Romanick <ian.d.romanick at intel.com>
>>> Cc: Brian Paul <brianp at vmware.com>
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA&m=CvxXt0YOXugGkbbzyxn0jAoAF0A6dRVbzGLLUqFneB8&s=NKrvsG5BEf-hY9B40F25ozkFXQA9YzWqK8P4QpZ5Xtc&e=
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA&m=CvxXt0YOXugGkbbzyxn0jAoAF0A6dRVbzGLLUqFneB8&s=NKrvsG5BEf-hY9B40F25ozkFXQA9YzWqK8P4QpZ5Xtc&e=
>>
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA&m=CvxXt0YOXugGkbbzyxn0jAoAF0A6dRVbzGLLUqFneB8&s=NKrvsG5BEf-hY9B40F25ozkFXQA9YzWqK8P4QpZ5Xtc&e=
>