[Mesa-dev] [PATCH 19/22 v3] i965/fs: Merge CMP and SEL into CSEL on Gen8+

[Kenneth Graunke]

On Wednesday, February 28, 2018 12:20:28 PM PST Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> v2: Fix several problems handling inverted predicates.  Add a much
> bigger comment around the BRW_CONDITIONAL_NZ case.
> 
> v3: Allow uniforms and shader inputs as sources for the original SEL and
> CMP instructions.  This enables a LOT more shaders to receive CSEL
> merging (5816 vs 8564 on SKL).
> 
> Broadwell and Skylake had similar results. (Broadwell shown)
> helped: 8527
> HURT: 0
> helped stats (abs) min: 1 max: 27 x̄: 2.44 x̃: 1
> helped stats (rel) min: 0.03% max: 17.80% x̄: 1.12% x̃: 0.70%
> 95% mean confidence interval for instructions value: -2.51 -2.36
> 95% mean confidence interval for instructions %-change: -1.15% -1.10%
> Instructions are helped.
> 
> total cycles in shared programs: 559442317 -> 558288357 (-0.21%)
> cycles in affected programs: 372699860 -> 371545900 (-0.31%)
> helped: 6748
> HURT: 1450
> helped stats (abs) min: 1 max: 32000 x̄: 182.41 x̃: 12
> helped stats (rel) min: <.01% max: 66.08% x̄: 3.42% x̃: 0.70%
> HURT stats (abs)   min: 1 max: 2538 x̄: 53.08 x̃: 14
> HURT stats (rel)   min: <.01% max: 96.72% x̄: 3.32% x̃: 0.90%
> 95% mean confidence interval for cycles value: -179.01 -102.51
> 95% mean confidence interval for cycles %-change: -2.37% -2.08%
> Cycles are helped.
> 
> LOST:   0
> GAINED: 6
> 
> No changes on earlier platforms.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>

Nice, thanks for doing this, Ian!

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180305/a362a785/attachment.sig>