[Mesa-dev] [PATCH] Revert "nir: bump loop unroll limit to 96."

Dave Airlie airlied at gmail.com
Tue Mar 6 05:49:46 UTC 2018


On 6 March 2018 at 13:59, Timothy Arceri <tarceri at itsqueeze.com> wrote:
> On 06/03/18 14:48, Timothy Arceri wrote:
>>
>> This reverts commit 2d36efdb7f18f061c519dbb93f6058bf161aad33.
>>
>> This raised limit turns out to harmful for more complex shaders,
>> it causes excessive spilling in some Bioshock Infinite shaders.
>
>
> While not as bad as Bioshock (which went from 0 -> 268 in three shaders)
> Dirt Showdown VGPR spilling went from 40 -> 67 and 0 -> 17 in a couple of
> shaders also as a result of loop unrolling.

Okay!

Reviewed-by: Dave Airlie <airlied at redhat.com>

Dave.


More information about the mesa-dev mailing list