[Mesa-dev] [PATCH 20/29] intel/isl/format: Add field locations informations to channel_layout

[Jason Ekstrand]

On Tue, Mar 6, 2018 at 9:46 AM, Pohjolainen, Topi <
topi.pohjolainen at gmail.com> wrote:

> On Tue, Mar 06, 2018 at 09:11:18AM -0800, Jason Ekstrand wrote:
> > On Tue, Mar 6, 2018 at 1:54 AM, Pohjolainen, Topi <
> > topi.pohjolainen at gmail.com> wrote:
> >
> > > On Fri, Jan 26, 2018 at 05:59:49PM -0800, Jason Ekstrand wrote:
> > > >  class Format(object):
> > > > @@ -160,7 +163,14 @@ class Format(object):
> > > >          self.l = Channel(line[9])
> > > >          self.i = Channel(line[10])
> > > >          self.p = Channel(line[11])
> > > > -        self.order = line[12]
> > > > +
> > > > +        # Set the start bit value for each channel
> > > > +        order = line[12].strip()
> > >
> > > You aren't setting "self.order" anymore?
> > >
> >
> > No.  Nothing was using it.  It doesn't really matter to me whether we
> store
> > it in the Format object or not.
>
> So it is not really needed in the previous patch then?
>

Correct.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180306/212754e5/attachment-0001.html>