[Mesa-dev] [PATCH 0/5] Fix meson omx compilation

[Dylan Baker]

Quoting Julien Isorce (2018-03-07 06:38:16)
> Thanks a lot for the fixes.
> There is small issue, if fails to build with meson with 'auto' if tizonia is
> installed but not bellagio because ENABLE_ST_OMX_BELLAGIO will remain defined.
> Though it can be added afterward, and the series is:

Oops, thats a tiny fix, just put the pre_args += ... in dep_omx.found() block.
Should probably do the same for tizonia.

> Tested-by: Julien Isorce <julien.isorce at gmail.com>
> 
> On 7 March 2018 at 13:44, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> 
>     On Tuesday, 2018-03-06 11:57:11 -0800, Dylan Baker wrote:
>     > This fixes a couple of problems with the meson build support for the
>     > recent omx tizonia integration, namely that it breaks a lot of
>     > previously working meson configurations.
> 
>     Thanks! Series is:
>     Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> 
>     >
>     > The biggest change in here is the reintroduction of the 'auto' flag to
>     > -Dgallium-omx. This allows configurations that lack tizonia, or that
>     > otherwise can't build the omx tracker (i965, and gallium drivers other
>     > than r600, radeon, or nouveau) to build without intervention.
>     >
>     > This also fixes some style things, but those are pretty trivial.
>     >
>     > Dylan Baker (5):
>     >   meson: combine state trackers and target if blocks
>     >   meson: fix tizonia compilation
>     >   meson: Re-add auto option for omx
>     >   meson: Use include directory variables instead of traversing
>     >   meson: Fix indent in omx meson.build
>     >
>     >  meson.build                                | 67
>     +++++++++++++++++++----------
>     >  meson_options.txt                          |  4 +-
>     >  src/egl/meson.build                        |  5 ++-
>     >  src/gallium/meson.build                    | 30 ++++---------
>     >  src/gallium/state_trackers/dri/meson.build |  2 +
>     >  src/gallium/state_trackers/omx/meson.build | 69
>     +++++++++++++++---------------
>     >  src/gbm/meson.build                        |  2 +-
>     >  7 files changed, 95 insertions(+), 84 deletions(-)
>     >
>     > --
>     > 2.16.2
>     >
>     > _______________________________________________
>     > mesa-dev mailing list
>     > mesa-dev at lists.freedesktop.org
>     > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>     _______________________________________________
>     mesa-dev mailing list
>     mesa-dev at lists.freedesktop.org
>     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180307/979220fe/attachment.sig>