[Mesa-dev] [PATCH] radv: drop assert on bindingDescriptorCount > 0

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Mar 8 08:13:08 UTC 2018


Yeah, noticed that CTS fail this morning too. :)

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 03/08/2018 01:16 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> The spec is pretty clear that this can be 0, and that it operates
> as a reserved binding.
> 
> Fixes:
> dEQP-VK.binding_model.descriptor_update.empty_descriptor.uniform_buffer
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>   src/amd/vulkan/radv_descriptor_set.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c
> index daff7b2fcd..3d56f8c217 100644
> --- a/src/amd/vulkan/radv_descriptor_set.c
> +++ b/src/amd/vulkan/radv_descriptor_set.c
> @@ -137,7 +137,6 @@ VkResult radv_CreateDescriptorSetLayout(
>   		}
>   
>   		set_layout->size = align(set_layout->size, alignment);
> -		assert(binding->descriptorCount > 0);
>   		set_layout->binding[b].type = binding->descriptorType;
>   		set_layout->binding[b].array_size = binding->descriptorCount;
>   		set_layout->binding[b].offset = set_layout->size;
> 


More information about the mesa-dev mailing list