[Mesa-dev] [v5 PATCH 0/6] ARB_spirv_extensions support in Mesa and i965

Alejandro Piñeiro apinheiro at igalia.com
Thu Mar 8 15:00:13 UTC 2018


Hi,

This series is the latest version of the support for
ARB_spirv_extensions on i965. The patches are basically the same that
v4 series we sent some time ago. This is rebased against master and
updated due the changes for the support of SPV_AMD_gcn_shader (sorry
for missing that one). So it includes a new patch compared with
previous versions. This new patch touches radv, that I can't test
easily, so I would welcome some testing here.

As with previous versions it was split from a previous series that
included also support for gl_spirv, but since this is an independent
extension, we have chosen to send it separately to streamline review
of the two series.

This extension however depends on gl_spirv, so it should be applied on
top of the v5 series I just sent for gl_spirv.

Although all the patches gathered some feedback, the only with a Rb is
the first one.

A tree of this series can be found at
<https://github.com/Igalia/mesa/tree/arb_spirv_extensions-series-v5>.

Thanks for reviewing

Alejandro Piñeiro (6):
  spirv_extensions: add GL_ARB_spirv_extensions boilerplate
  spirv/radv: add AMD_gcn_shader capability, remove current extensions
  spirv_extensions: add list of extensions and to_string method
  spirv_extensions: define spirv_extensions_supported
  spirv_extensions: add spirv_supported_extensions on gl_constants
  spirv_extensions: i965: initialize SPIR-V extensions

 src/amd/vulkan/radv_shader.c                |  2 -
 src/compiler/Makefile.sources               |  2 +
 src/compiler/nir/meson.build                |  2 +
 src/compiler/shader_info.h                  |  4 --
 src/compiler/spirv/nir_spirv.h              |  1 -
 src/compiler/spirv/spirv_extensions.c       | 80 +++++++++++++++++++++++++++++
 src/compiler/spirv/spirv_extensions.h       | 63 +++++++++++++++++++++++
 src/compiler/spirv/spirv_to_nir.c           |  2 +-
 src/mapi/glapi/gen/ARB_spirv_extensions.xml | 13 +++++
 src/mapi/glapi/gen/Makefile.am              |  1 +
 src/mapi/glapi/gen/gl_API.xml               |  4 ++
 src/mapi/glapi/gen/meson.build              |  1 +
 src/mesa/Makefile.sources                   |  2 +
 src/mesa/drivers/dri/i965/brw_context.c     | 10 +++-
 src/mesa/main/context.c                     |  2 +
 src/mesa/main/extensions_table.h            |  1 +
 src/mesa/main/get.c                         |  6 +++
 src/mesa/main/get_hash_params.py            |  3 ++
 src/mesa/main/getstring.c                   | 13 +++++
 src/mesa/main/mtypes.h                      |  4 ++
 src/mesa/main/spirv_extensions.c            | 60 ++++++++++++++++++++++
 src/mesa/main/spirv_extensions.h            | 49 ++++++++++++++++++
 src/mesa/meson.build                        |  2 +
 23 files changed, 318 insertions(+), 9 deletions(-)
 create mode 100644 src/compiler/spirv/spirv_extensions.c
 create mode 100644 src/compiler/spirv/spirv_extensions.h
 create mode 100644 src/mapi/glapi/gen/ARB_spirv_extensions.xml
 create mode 100644 src/mesa/main/spirv_extensions.c
 create mode 100644 src/mesa/main/spirv_extensions.h

-- 
2.14.1



More information about the mesa-dev mailing list