[Mesa-dev] [PATCH v2 04/18] nir: kernel entrypoints can have arguments

Karol Herbst kherbst at redhat.com
Thu Mar 8 15:25:50 UTC 2018


From: Rob Clark <robdclark at gmail.com>

This assert is not valid for OpenCL kernels.

TODO can we somehow conditionally assert based on glsl vs cl??

Signed-off-by: Rob Clark <robdclark at gmail.com>
Signed-off-by: Karol Herbst <kherbst at redhat.com>
---
 src/compiler/nir/nir.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
index eb21f42263..e3b1cc35d8 100644
--- a/src/compiler/nir/nir.h
+++ b/src/compiler/nir/nir.h
@@ -1974,7 +1974,6 @@ nir_shader_get_entrypoint(nir_shader *shader)
    struct exec_node *func_node = exec_list_get_head(&shader->functions);
    nir_function *func = exec_node_data(nir_function, func_node, node);
    assert(func->return_type == glsl_void_type());
-   assert(func->num_params == 0);
    assert(func->impl);
    return func->impl;
 }
-- 
2.14.3



More information about the mesa-dev mailing list