[Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

Keith Packard keithp at keithp.com
Thu Mar 8 18:04:03 UTC 2018


Eric Engestrom <eric.engestrom at imgtec.com> writes:

> I'm still slightly bothered by the build options inconsistency between
> autotools: reuse --with-platform=drm
> meson:     new       -D platform=display
>
> I'd be happy with either one being used everywhere, but from what you
> said last time I think you'd prefer to reuse `platform=drm`; can we
> drop the meson hunks above and use `with_platform_drm` in
> src/vulkan/wsi/meson.build?

Thanks for the reminder; I got totally bound up in Jason's code fixes
and rebasing onto current master that I just forgot. I've got three tiny
patches on my drm-lease-v2 branch which does this (one for core, one for
anv, one for radv).

> About that hunk, have you looked at my patch?
> https://patchwork.freedesktop.org/patch/206818/

Yeah, that definitely looks nicer. I've reviewed it to make sure calling
the various finish functions is harmless when called before the matching
init function. If it gets applied before my series, I'll adapt :-)

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180308/ccd87d2c/attachment.sig>


More information about the mesa-dev mailing list