[Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Michel Dänzer michel at daenzer.net
Thu Mar 8 18:37:25 UTC 2018


On 2018-03-08 06:10 PM, Dylan Baker wrote:
> 
> When I was given commit access I was told that I should wait 24 hours
> after sending patches unless they were trivial or fixed something
> critical, ie, without them you can't compile or nothing works.

FWIW, I think that's a good rule, and I follow it.

If one doesn't wait for at least 24 hours, e.g. somebody living in a
different timezone may not get a chance to send feedback before the
patch is applied. So it's kind of implying one isn't interested in
feedback from such people.


> I know we've always given a lot of flexibility to vendor specific code
> (i965 or nouveau), but you hope everyone can understand my frustration
> with a 56 patch series that I sent review for 8 hours after it was
> posted to the list and I got told "Oh, I merged that hours ago,
> patches welcome." 

I can. I guess Jason got a bit carried away by the Vulkan 1.1 excitement.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 224 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180308/4f56b52f/attachment.sig>


More information about the mesa-dev mailing list