[Mesa-dev] [PATCH 2/3] meson: use relative paths in megadriver symlinks

[Dylan Baker]

Quoting Dylan Baker (2018-03-08 11:25:20)
> Quoting Greg V (2018-03-06 11:16:04)
> > e.g. libvdpau_radeonsi.so(.1(.0)) were pointing to the absolute
> > build-time path of libvdpau_radeonsi.so.1.0.0, which caused trouble
> > when packaging the libraries.
> > ---
> >  bin/install_megadrivers.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
> > index 86bfa35918..ce947b4332 100755
> > --- a/bin/install_megadrivers.py
> > +++ b/bin/install_megadrivers.py
> > @@ -58,7 +58,7 @@ def main():
> >              while ext != '.so':
> >                  if os.path.exists(name):
> >                      os.unlink(name)
> > -                os.symlink(driver, name)
> > +                os.symlink(os.path.relpath(driver), name)
> 
> I think that driver is wrong here, I think that this should be
> `os.symlink(each, name)`
> 
> In my testing these generated the same code.

By "these" I mean os.path.relpath(driver) and each

> 
> Dylan
> 
> >                  name, ext = os.path.splitext(name)
> >          finally:
> >              os.chdir(ret)
> > -- 
> > 2.16.2
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180308/fe9c2c67/attachment.sig>