[Mesa-dev] [PATCH] cmake: Warn that MSVC is unmaintained.

Jose Fonseca jfonseca at vmware.com
Mon Mar 12 09:19:06 UTC 2018


It has been broken for a while, and not much interest from our side
in keeping it going, as most of us are using MinGW cross-compilers
anyway.

I'm not sure if there are other people interested on MSVC, so just
warn for the time being.

Also tone down the MSVC warnings, so they don't overwhelm the error
messages.
---
 CMakeLists.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index aaa5329c..1f63316d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -108,13 +108,17 @@ if (WIN32)
 endif (WIN32)
 
 if (MSVC)
+	message (WARNING "MSVC builds are unmainted.  MinGW-w64 is recommended.")
+
 	# Enable math constants defines
 	add_definitions (-D_USE_MATH_DEFINES)
 
 	# Silence several MSVC pedantic warnings
 	add_definitions (-D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS)
 	add_definitions (-D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS)
+	add_definitions (-wd4018) # signed/unsigned mismatch
 	add_definitions (-wd4244) # conversion' conversion from 'type1' to 'type2', possible loss of data
+	add_definitions (-wd4305) # truncation from 'type1' to 'type2'
 
 	# Use static runtime
 	# http://www.cmake.org/Wiki/CMake_FAQ#How_can_I_build_my_MSVC_application_with_a_static_runtime.3F
-- 
2.14.1



More information about the mesa-dev mailing list