[Mesa-dev] [PATCH 2/2] gbm: Add support for 10bpp BGR formats

[Mario Kleiner]

Tested under nouveau-kms with a hacked kmscube to use
GBM_FORMAT_ABGR2101010 successfully, and reject
GBM_FORMAT_XBGR2101010, GBM_FORMAT_ARGB2101010,
and GBM_FORMAT_XRGB2101010 as expected.

Reviewed-and-Tested-by: Mario Kleiner <mario.kleiner.de at gmail.com>

On Fri, Mar 9, 2018 at 4:45 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Series is Tested-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
> kmscube and weston both start. The terminal app in weston shows
> correct colors. I got a (weston) crash when trying to run
> egltri_wayland from mesa-demos, but that could be for a million
> different reasons.
>
> On Thu, Mar 8, 2018 at 12:36 PM, Daniel Stone <daniels at collabora.com> wrote:
>> Add support for XBGR2101010 and ABGR2101010 formats.
>>
>> Signed-off-by: Daniel Stone <daniels at collabora.com>
>> ---
>>  src/gbm/backends/dri/gbm_dri.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
>> index df20db40218..b3d6ceb15a3 100644
>> --- a/src/gbm/backends/dri/gbm_dri.c
>> +++ b/src/gbm/backends/dri/gbm_dri.c
>> @@ -580,6 +580,14 @@ static const struct gbm_dri_visual gbm_dri_visuals_table[] = {
>>       GBM_FORMAT_ARGB2101010, __DRI_IMAGE_FORMAT_ARGB2101010,
>>       { 0x3ff00000, 0x000ffc00, 0x000003ff, 0xc0000000 },
>>     },
>> +   {
>> +     GBM_FORMAT_XBGR2101010, __DRI_IMAGE_FORMAT_XBGR2101010,
>> +     { 0x000003ff, 0x000ffc00, 0x3ff00000, 0x00000000 },
>> +   },
>> +   {
>> +     GBM_FORMAT_ABGR2101010, __DRI_IMAGE_FORMAT_ABGR2101010,
>> +     { 0x000003ff, 0x000ffc00, 0x3ff00000, 0xc0000000 },
>> +   },
>>  };
>>
>>  /* The two GBM_BO_FORMAT_[XA]RGB8888 formats alias the GBM_FORMAT_*
>> --
>> 2.14.3
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev