[Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

Dylan Baker dylan at pnwbakers.com
Mon Mar 12 17:16:33 UTC 2018


Quoting Emil Velikov (2018-03-12 09:09:50)
> On 12 March 2018 at 15:01, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> > Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > ---
> > Dylan, was there any reason to have -Werror=missing-prototypes and
> > -Werror=implicit-function-declaration in C but not C++?
> > Both sound to me like something we always want.
> 
> Seems to be copied from the autotools setup.
> Reason being, both are not valid for C++.
> Although since we probe for them, everything should be fine. The C++
> test will bail out and the flags won't be set during the actual build.

Which is why I left them separate, since it avoids having to compile for
arguments we know that C++ doesn't support. It probably doesn't matter either
way,

Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180312/6df030c3/attachment-0001.sig>


More information about the mesa-dev mailing list