[Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: correct DRI3 version in comment

[Daniel Stone]

Hi Emil,

On 13 March 2018 at 11:40, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> During development the version was bumped, yet the comment did not get
> an update.
>
> Cc: Daniel Stone <daniels at collabora.com>
> Fixes: c80c08e2260 ("vulkan/wsi/x11: Add support for DRI3 v1.2")
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

These are both:
Reviewed-by: Daniel Stone <daniels at collabora.com>

> Mildly related: the DRI3 (and DRI2) version query implementation is
> broken. In a sense that the server can return version greater than the
> client one.
>
> I can set a fix for that, although it might regress some broken (yet
> barely working) programs.
>
> From the DRI3 proto, with some emphasis from your truly:
>
>     The client sends the highest supported version to the server
>     and the server sends the highest version it supports, but _no_
>     _higher_ than the _requested version_.

Given there's only been 1.0 until a week or two ago, it shouldn't
cause any issues, you'd hope. Seems like a reasonable patch to me.

Cheers,
Daniel