[Mesa-dev] [PATCH 2/4] anv: Silence compiler warnings about uninitialized bind_offset.
Lionel Landwerlin
lionel.g.landwerlin at intel.com
Tue Mar 13 18:07:50 UTC 2018
On 13/03/18 17:38, Eric Anholt wrote:
> This is a legitimate warning: if anv's blorp_alloc_binding_table() throws
> an error from anv_cmd_buffer_alloc_blorp_binding_table(), we silently
> continue to use this undefined value. The rest of this code doesn't seem
> very allocation-error-proof, though, either.
>
> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
> src/intel/blorp/blorp_genX_exec.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h
> index 1348659233c4..5b59af491ee8 100644
> --- a/src/intel/blorp/blorp_genX_exec.h
> +++ b/src/intel/blorp/blorp_genX_exec.h
> @@ -1388,7 +1388,7 @@ blorp_emit_surface_states(struct blorp_batch *batch,
> const struct blorp_params *params)
> {
> const struct isl_device *isl_dev = batch->blorp->isl_dev;
> - uint32_t bind_offset, surface_offsets[2];
> + uint32_t bind_offset = 0, surface_offsets[2];
> void *surface_maps[2];
>
> MAYBE_UNUSED bool has_indirect_clear_color = false;
More information about the mesa-dev
mailing list