[Mesa-dev] [PATCH 2/2] autotools: add -I/src/egl to tizonia

[Emil Velikov]

On 13 March 2018 at 18:23, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Emil Velikov (2018-03-13 09:41:47)
>> On 7 March 2018 at 23:13, Dylan Baker <dylan at pnwbakers.com> wrote:
>> > meson got the same fix.
>> >
>> > cc: Emil Veliov <emil.l.velikov at gmail.com>
>> > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
>> > ---
>> >
>> > I don't know hat the "right" fix is here Emil, I just picked one and applied it
>> > to both meson and autotools.
>> >
>> Hmm I've misread Tim's reply - I've assumed this has landed as well.
>>
>> >  src/gallium/state_trackers/omx/tizonia/Makefile.am | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/src/gallium/state_trackers/omx/tizonia/Makefile.am b/src/gallium/state_trackers/omx/tizonia/Makefile.am
>> > index 3149afa7bbb..0eac85a319e 100644
>> > --- a/src/gallium/state_trackers/omx/tizonia/Makefile.am
>> > +++ b/src/gallium/state_trackers/omx/tizonia/Makefile.am
>> > @@ -27,6 +27,7 @@ AM_CFLAGS = \
>> >         -I$(top_srcdir)/src/mesa \
>> >         -I$(top_builddir)/src/mesa/drivers/dri/common \
>> >         -I$(top_srcdir)/src/mesa/drivers/dri/common \
>> > +       -I$(top_srcdir)/src/egl \
>>
>> From a quick look no obvious reason comes up why we'd need this.
>> The meson patch does not mention anything either - can you please
>> share the error message that you've seen?
>> Be that with meson or autotools.
>>
>> Thanks
>> Emil
>
> The tizonia state tracker includes some headers as "egl/..." Someone else had
> sent a patch to make that import relative, but the meson patch that added egl as
> an include path had already landed so I sent this.
>
I cannot spot anything - do you have any keywords/message ID to look for?

The only thing I could find (include + egl) was the meson commit
7598dedfde49391564cdb3d355e7bd98e1880782.
Latter of which says "It needs to have ... " and not why.

Meh, it should hurt so let's merge it.
Acked-by: Emil Velikov <emil.velikov at collabora.com>

-Emil