[Mesa-dev] [PATCH shaderdb 2/3] run: new '--pci-id' option for overriding pci-id

[Kenneth Graunke]

On Monday, February 12, 2018 5:26:15 PM PDT Dongwon Kim wrote:
> Add a new option, '--pciid' to override a pci id of the target arch
> to support cross-architecture shader compilation. Not like "-p" option,
> it is for accepting any GFX devices supported by the driver.
> 
> Setting both "-p" and "--pciid" is blocked to avoid conflict.
> 
> Signed-off-by: Dongwon Kim <dongwon.kim at intel.com>
> ---
>  run.c | 44 ++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 42 insertions(+), 2 deletions(-)

Hi Dongwon,

It looks like this does the exact same thing as -p, but it accepts
arbitrary numerical PCI IDs instead of a platform name.  IMHO, I think
we should just make -p try parsing it as a number of it doesn't match
any of the names.  Then either -p bdw or -p 0x1616 would work.

It seems much less complicated that way.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180314/810c9c32/attachment.sig>