[Mesa-dev] [PATCH] configure: remove unneeded XCB_REQUIRED

[Dave Airlie]

On 15 March 2018 at 09:29, Andres Gomez <agomez at igalia.com> wrote:
> It is only used for dri3 and xcb-dri3 and xcb-present were already
> mandating the minimal version, which is incoherent with the xcb one.

We are in the middle of a thread discussing this area already,
probably don't need
this patch at this stage. Let's solve the problem first.

Dave.
>
> This also makes configure.ac more homogeneous with other modules, like
> dri2 or glx, which also need xcb but get the minimal version from
> xcb-dri2 or xcb-glx, respectively.
>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Cc: Eric Engestrom <eric.engestrom at imgtec.com>
> Signed-off-by: Andres Gomez <agomez at igalia.com>
> ---
>  configure.ac | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 621dc328d90..4392a427699 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -90,7 +90,6 @@ LIBVA_REQUIRED=0.38.0
>  VDPAU_REQUIRED=1.1
>  WAYLAND_REQUIRED=1.11
>  WAYLAND_PROTOCOLS_REQUIRED=1.8
> -XCB_REQUIRED=1.9.3
>  XCBDRI2_REQUIRED=1.8
>  XCBDRI3_REQUIRED=1.13
>  XCBGLX_REQUIRED=1.8.1
> @@ -1850,7 +1849,7 @@ fi
>  if test x"$enable_dri3" = xyes; then
>      DEFINES="$DEFINES -DHAVE_DRI3"
>
> -    dri3_modules="x11-xcb xcb >= $XCB_REQUIRED xcb-dri3 >= $XCBDRI3_REQUIRED xcb-xfixes xcb-present >= $XCBPRESENT_REQUIRED xcb-sync xshmfence >= $XSHMFENCE_REQUIRED"
> +    dri3_modules="x11-xcb xcb xcb-dri3 >= $XCBDRI3_REQUIRED xcb-xfixes xcb-present >= $XCBPRESENT_REQUIRED xcb-sync xshmfence >= $XSHMFENCE_REQUIRED"
>      PKG_CHECK_MODULES([XCB_DRI3], [$dri3_modules])
>  fi
>
> --
> 2.16.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev