[Mesa-dev] [PATCH mesa 1/2] Add processor topology calculation implementation for Darwin/OSX targets.

Matt Turner mattst88 at gmail.com
Wed Mar 14 23:41:58 UTC 2018


Subject should have a swr prefix or similar.

On Wed, Mar 14, 2018 at 4:19 PM, Jeremy Huddleston Sequoia
<jeremyhu at apple.com> wrote:
> From: Apple SWE <jeremyhu at apple.com>

Explain?

>
> The implementation for bootstrapping SWR on Darwin targets is based on the Linux version.
> Instead of reading the output of /proc/cpuinfo, sysctlbyname is used to determine the
> physical identifiers, processor identifiers, core counts and thread-processor affinities.
>
> With this patch, it is possible to use SWR as an alternate renderer on OSX to softpipe and
> llvmpipe.

All of these look like they're too long to fix in 80 columns in git show.

> Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

I'm guessing you're just pushing code someone else wrote...

> Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

We don't  have a DCO, so Signed-off-by has no meaning. Worse, in the
case we added a DCO in the future, all of the stupid Signed-off-by's
people have been cargo culting for years would confuse everything.
Please stop doing it.

Please don't push code to maintained drivers without going through the
mailing list. I feel like I shouldn't have to say that.


More information about the mesa-dev mailing list