[Mesa-dev] [PATCH 1/2] anv/pipeline: fail if tcs/tes compile fail

[Lionel Landwerlin]

Fixes: e50d4807a35e679 ("anv: Compile TCS/TES shaders.")

On 15/03/18 10:14, Lionel Landwerlin wrote:
> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>
> On 15/03/18 00:20, Caio Marcelo de Oliveira Filho wrote:
>> ---
>>   src/intel/vulkan/anv_pipeline.c | 16 +++++++++-------
>>   1 file changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/src/intel/vulkan/anv_pipeline.c 
>> b/src/intel/vulkan/anv_pipeline.c
>> index 9cfd16df2a..cb34f3be77 100644
>> --- a/src/intel/vulkan/anv_pipeline.c
>> +++ b/src/intel/vulkan/anv_pipeline.c
>> @@ -1349,13 +1349,15 @@ anv_pipeline_init(struct anv_pipeline *pipeline,
>>      }
>>        if (modules[MESA_SHADER_TESS_EVAL]) {
>> -      anv_pipeline_compile_tcs_tes(pipeline, cache, pCreateInfo,
>> - modules[MESA_SHADER_TESS_CTRL],
>> - pStages[MESA_SHADER_TESS_CTRL]->pName,
>> - pStages[MESA_SHADER_TESS_CTRL]->pSpecializationInfo,
>> - modules[MESA_SHADER_TESS_EVAL],
>> - pStages[MESA_SHADER_TESS_EVAL]->pName,
>> - pStages[MESA_SHADER_TESS_EVAL]->pSpecializationInfo);
>> +      result = anv_pipeline_compile_tcs_tes(pipeline, cache, 
>> pCreateInfo,
>> + modules[MESA_SHADER_TESS_CTRL],
>> + pStages[MESA_SHADER_TESS_CTRL]->pName,
>> + pStages[MESA_SHADER_TESS_CTRL]->pSpecializationInfo,
>> + modules[MESA_SHADER_TESS_EVAL],
>> + pStages[MESA_SHADER_TESS_EVAL]->pName,
>> + pStages[MESA_SHADER_TESS_EVAL]->pSpecializationInfo);
>> +      if (result != VK_SUCCESS)
>> +         goto compile_fail;
>>      }
>>        if (modules[MESA_SHADER_GEOMETRY]) {
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev