[Mesa-dev] [PATCH 1/4] mesa: add INTEL_blackhole_render

[Lionel Landwerlin]

On 15/03/18 16:03, Emil Velikov wrote:
> HI Lionel,
>
> On 15 March 2018 at 14:24, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> ---
>>   include/GL/glext.h               |  5 +++++
>>   include/GLES2/gl2ext.h           |  5 +++++
>>   src/mapi/glapi/registry/gl.xml   |  8 +++++++-
> Please update these by pulling the latest files from Khronos. See git
> log for examples.

A few differences from the Khronos files made me think that we didn't 
pull files directly.
Will change this.

>
>> +EXT(INTEL_blackhole_render                  , INTEL_blackhole_render                 , GLL, GLC,  x , ES2, 2018)
> Spec says "OpenGL 3.0 is required" so GLL + GLC should become 30

Thanks, I'm never sure about those things :(

> Wrt GLES side the spec does not mention anything - is that ES1, ES2,
> which version etc.
> Worth keeping it simple and update the spec to say ES2+?

ES2+ indeed.

>
> The patch implements Enable/Disable, yet IsEnabled is missing.

Oops... I thought that was autogenerated for some reason :/

Thanks a lot!

>
> HTH
> Emil
>