[Mesa-dev] [PATCH 1/7] radv: only display options that are enabled

[Samuel Pitoiset]

On 03/15/2018 05:06 PM, Bas Nieuwenhuizen wrote:
> One comment on patch 7, and the LLVM dump ordering issue we debugged
> earlier (where we should dump before compiling), otherwise the series
> is

Yes, v2 was here:

https://cgit.freedesktop.org/~hakzsam/mesa/commit/?h=radv_llvm_ir&id=904e9e336cbe94bb6e968ef74e549d0c5c75b633

Thanks Bas!

> 
> Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
> 
> On Wed, Mar 14, 2018 at 12:27 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   src/amd/vulkan/radv_debug.c | 28 ++++++++++++++++------------
>>   1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c
>> index c8794d06ea..f3b79004f6 100644
>> --- a/src/amd/vulkan/radv_debug.c
>> +++ b/src/amd/vulkan/radv_debug.c
>> @@ -598,23 +598,27 @@ radv_dump_enabled_options(struct radv_device *device, FILE *f)
>>   {
>>          uint64_t mask;
>>
>> -       fprintf(f, "Enabled debug options: ");
>> +       if (device->instance->debug_flags) {
>> +               fprintf(f, "Enabled debug options: ");
>>
>> -       mask = device->instance->debug_flags;
>> -       while (mask) {
>> -               int i = u_bit_scan64(&mask);
>> -               fprintf(f, "%s, ", radv_get_debug_option_name(i));
>> +               mask = device->instance->debug_flags;
>> +               while (mask) {
>> +                       int i = u_bit_scan64(&mask);
>> +                       fprintf(f, "%s, ", radv_get_debug_option_name(i));
>> +               }
>> +               fprintf(f, "\n");
>>          }
>> -       fprintf(f, "\n");
>>
>> -       fprintf(f, "Enabled perftest options: ");
>> +       if (device->instance->perftest_flags) {
>> +               fprintf(f, "Enabled perftest options: ");
>>
>> -       mask = device->instance->perftest_flags;
>> -       while (mask) {
>> -               int i = u_bit_scan64(&mask);
>> -               fprintf(f, "%s, ", radv_get_perftest_option_name(i));
>> +               mask = device->instance->perftest_flags;
>> +               while (mask) {
>> +                       int i = u_bit_scan64(&mask);
>> +                       fprintf(f, "%s, ", radv_get_perftest_option_name(i));
>> +               }
>> +               fprintf(f, "\n");
>>          }
>> -       fprintf(f, "\n");
>>   }
>>
>>   static void
>> --
>> 2.16.2
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev