[Mesa-dev] [PATCH] st/dri: don't set queryDmaBufFormats/queryDmaBufModifiers if the driver does not implement it

Emil Velikov emil.l.velikov at gmail.com
Fri Mar 16 14:57:49 UTC 2018


Cc-ing the author of the 'offending' commit - Nicolai

On 15 March 2018 at 16:27, Michal Srb <msrb at suse.com> wrote:
> This is equivalent to commit a65db0ad1c3, but for dri_kms_init_screen. Without
> this gbm_dri_is_format_supported always returns false.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104926
> ---
Thanks for the nice work Michal. Patch looks spot on.

Fixes: e14fe41e0bf ("st/dri: implement createImageFromRenderbuffer(2)")
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

In practise we should be able to unity/remove the duplication across
dri_kms_init_screen and dri2_init_screen.
The pipe_loader_drm_probe_fd vs pipe_loader_sw_probe_kms is the only
change. One might need to wire up the DRM_CONF_SHARE_FD for the
driver.

Any takers?

-Emil


More information about the mesa-dev mailing list