[Mesa-dev] [PATCH] radv: enable VK_EXT_depth_range_unrestricted

[Bas Nieuwenhuizen]

I think we still need to support image->image copies with depth
outside the range [0,1]. There was no explicit restriction on that,
but before enabling this it is impossible to get an image with depth
not in [0,1] so we did not have to care. But the gfx path uses the
depth HW with no depth bound so it gets clamped to [0,1].

If we don't need to handle NaNs it might be worth checking if setting
the bounds to [-INF, INF] works?


On Mon, Mar 19, 2018 at 2:54 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> This extension just removes restrictions on minDepth/maxDepth,
> minDepthBounds/maxDepthBounds and VkClearDepthStencilValue::depth.
>
> As we don't clamp anything, we can enable the extension for free.
>
> The two following CTS tests now pass:
> dEQP-VK.draw.inverted_depth_ranges.nodepthclamp_depth_range_unrestricted
> dEQP-VK.draw.inverted_depth_ranges.depthclamp_depth_range_unrestricted
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_extensions.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py
> index bfee1f76fa..896cc62459 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -86,6 +86,7 @@ EXTENSIONS = [
>      Extension('VK_KHR_xlib_surface',                      6, 'VK_USE_PLATFORM_XLIB_KHR'),
>      Extension('VK_KHR_multiview',                         1, True),
>      Extension('VK_EXT_debug_report',                      9, True),
> +    Extension('VK_EXT_depth_range_unrestricted',          1, True),
>      Extension('VK_EXT_discard_rectangles',                1, True),
>      Extension('VK_EXT_external_memory_dma_buf',           1, True),
>      Extension('VK_EXT_external_memory_host',              1, 'device->rad_info.has_userptr'),
> --
> 2.16.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev