[Mesa-dev] [PATCH] radv: don't export NULL layer.

Dave Airlie airlied at gmail.com
Mon Mar 19 20:04:15 UTC 2018


From: Dave Airlie <airlied at redhat.com>

We have some cases where in subpass we want the layer but having
it be 0 and loaded in the frag shader without the vertex shader
exporting it is fine.

So don't export the layer if we don't have a value to put in it.

Fixes: d4c74aed7a8 (radv/multiview: mark layer_input if we have input attachments.)
---
 src/amd/vulkan/radv_nir_to_llvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c
index 63dd8efb3a7..6fc2fe9184f 100644
--- a/src/amd/vulkan/radv_nir_to_llvm.c
+++ b/src/amd/vulkan/radv_nir_to_llvm.c
@@ -2349,7 +2349,7 @@ handle_vs_outputs_post(struct radv_shader_context *ctx,
 		outinfo->export_prim_id = true;
 	}
 
-	if (export_layer_id) {
+	if (export_layer_id && layer_value) {
 		LLVMValueRef values[4];
 
 		values[0] = layer_value;
-- 
2.14.3



More information about the mesa-dev mailing list