[Mesa-dev] [PATCH 1/2] i965: perf: fix a counter return type on hsw

Kenneth Graunke kenneth at whitecape.org
Mon Mar 19 21:10:17 UTC 2018


On Friday, March 16, 2018 8:03:58 AM PDT Lionel Landwerlin wrote:
> The equation code computes a float (percentage) yet the return type
> was an uint64_t.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_oa_hsw.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_oa_hsw.xml b/src/mesa/drivers/dri/i965/brw_oa_hsw.xml
> index ebc2bd79143..861cc1212a7 100644
> --- a/src/mesa/drivers/dri/i965/brw_oa_hsw.xml
> +++ b/src/mesa/drivers/dri/i965/brw_oa_hsw.xml
> @@ -1669,7 +1669,7 @@
>               />
>      <counter name="VS EU Stall"
>               description="The percentage of time in which vertex shaders were stalled on the EUs."
> -             data_type="uint64"
> +             data_type="float"
>               max_equation="100"
>               equation="A 3 READ $EuCoresTotalCount UDIV 100 UMUL $GpuCoreClocks FDIV"
>               underscore_name="vs_eu_stall"
> 

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180319/218be422/attachment.sig>


More information about the mesa-dev mailing list