[Mesa-dev] [PATCH 8/8] vc4: autotools: fix header inclusion in CFLAGS

[Juan A. Suarez Romero]

On Mon, 2018-03-19 at 18:51 +0000, Emil Velikov wrote:
> On 19 March 2018 at 17:49, Juan A. Suarez Romero <jasuarez at igalia.com> wrote:
> > Load NIR compiler headers from srcdir, not builddir.
> > ---
> >  src/gallium/drivers/vc4/Makefile.am | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/gallium/drivers/vc4/Makefile.am b/src/gallium/drivers/vc4/Makefile.am
> > index d65bf20e26d..abcad54f087 100644
> > --- a/src/gallium/drivers/vc4/Makefile.am
> > +++ b/src/gallium/drivers/vc4/Makefile.am
> > @@ -27,7 +27,7 @@ SIM_LDFLAGS = -lsimpenrose
> >  endif
> > 
> >  AM_CFLAGS = \
> > -       -I$(top_builddir)/src/compiler/nir \
> > +       -I$(top_srcdir)/src/compiler/nir \
> 
> I'd imagine the issue is because vc4_blit.c's nir_builder.h is missing
> "compiler/nir/" - while the rest of vc4 has the path prefix.
> As such, It would be better to stay consistent and update vc4_blit.c, right?
> 


Right! Didn't realize the other files were including the patch prefix.

I'll sent a v2 for this patch.


Thanks!


	J.A.

> As-it this patch will cause the in-tree generated header to be picked up.
> Latter is more of a gut feeling - haven't checked it.
> 
> -Emil
>