[Mesa-dev] [PATCH] dri3: Fix typo in version check

Dylan Baker dylan at pnwbakers.com
Tue Mar 20 16:24:27 UTC 2018


Quoting Daniel Stone (2018-03-20 09:17:21)
> The have-new-DRI3 codepaths would never actually properly trigger, since
> there was a typo in configure.ac which broke the version check. This
> went unnoticed but for an error in config.log if you looked closely
> enough.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> Reported-by: Lukas F. Hartmann <lukas at mntmn.com>
> Fixes: 7aeef2d4efdc ("dri3: allow building against older xcb (v3)")
> Cc: Dave Airlie <airlied at redhat.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index d1c8bb82dae..5074275211e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1852,7 +1852,7 @@ if test x"$enable_dri3" = xyes; then
>  
>      dri3_modules="x11-xcb xcb >= $XCB_REQUIRED xcb-dri3 xcb-xfixes xcb-present xcb-sync xshmfence >= $XSHMFENCE_REQUIRED"
>      PKG_CHECK_MODULES([XCB_DRI3], [$dri3_modules])
> -    dri3_modifier_modules="xcb-dri3 >= $XCBDRI3_MODIFIERS_REQUIRED xcb-present >= $XCBPRESENT_MODIFIERS_REQUIRES"
> +    dri3_modifier_modules="xcb-dri3 >= $XCBDRI3_MODIFIERS_REQUIRED xcb-present >= $XCBPRESENT_MODIFIERS_REQUIRED"
>      PKG_CHECK_MODULES([XCB_DRI3_MODIFIERS], [$dri3_modifier_modules], [have_dri3_modifiers=yes], [have_dri3_modifiers=no])
>  
>      if test "x$have_dri3_modifiers" == xyes; then
> -- 
> 2.16.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180320/b8042cbb/attachment.sig>


More information about the mesa-dev mailing list