[Mesa-dev] [PATCH] egl/wayland: Make swrast display_sync the correct queue

Daniel Stone daniel at fooishbar.org
Thu Mar 22 15:28:49 UTC 2018


On 22 March 2018 at 15:20, Derek Foreman <derekf at osg.samsung.com> wrote:
> commit 03dd9a88b0be17ff0ce91e92f6902a9a85ba584a introduced per surface
> queues, but the display_sync for swrast_commit_backbuffer remained on
> the old queue.  This is likely to break when dispatching the correct
> queue at the top of function (which can't dispatch the sync callback
> we're waiting for).
>
> The easiest known reproduction case is running weston-subsurfaces under
> weston --use-pixman

Oh dear. Pushed now with review. For future though, can you please use
the 'Fixes:' annotation, which in this case would've been for
03dd9a88b0be? Don't feel too bad though, because I also forgot to add
it when pushing.

Cheers,
Daniel


More information about the mesa-dev mailing list