[Mesa-dev] [PATCH v2 1/7] waylan-drm: do not distribute generated sources

[Emil Velikov]

On 22 March 2018 at 17:01, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi Juan,
>
> On 22 March 2018 at 16:49, Juan A. Suarez Romero <jasuarez at igalia.com> wrote:
>> Instead we will re-generate them again on building.
>
> Thanks for sending the v2 - that looks good to me. There was some kind
> of problem with having the sources in BUILT_SOURCES though, which Emil
> might be able to remember. Is it necessary to have it there,
> especially if we have hardcoded Makefile deps already?
>
BUILT_SOURCES is effectively "as you come in this folder, first
build/generate those files. regardless if you need them or not."
Which will effectively fail if wayland-scanner is missing.

When you remove them from the list, they will be generated only as
needed. Building with wayland will list those files as deps, hence
they'll be generated.

With that addressed the patch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Please push the non-controversial patches.

Thanks
Emil