[Mesa-dev] [PATCH] i965/perf: fix config registration when uploading to kernel

Kenneth Graunke kenneth at whitecape.org
Thu Mar 22 17:27:37 UTC 2018


On Thursday, March 22, 2018 9:02:11 AM PDT Lionel Landwerlin wrote:
> When registring configuration to the kernel for the first time, we run
> into an issue where the id number is not properly set. As a result
> when trying to use that id later on, we get an error.
> 
> This issue manifest itself the first time you use frameretrace after
> reboot, subsequent runs are fine.
> 
> Fixes: 27ee83eaf7e9 ("i965: perf: add support for userspace configurations")
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_performance_query.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c b/src/mesa/drivers/dri/i965/brw_performance_query.c
> index 8b3f38966ca..4144aa3c9b8 100644
> --- a/src/mesa/drivers/dri/i965/brw_performance_query.c
> +++ b/src/mesa/drivers/dri/i965/brw_performance_query.c
> @@ -1905,7 +1905,7 @@ init_oa_configs(struct brw_context *brw)
>           continue;
>        }
>  
> -      register_oa_config(brw, query, config_id);
> +      register_oa_config(brw, query, ret);
>        DBG("metric set: %s (added)\n", query->guid);
>     }
>  }
> 

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180322/e0f6c52b/attachment-0001.sig>


More information about the mesa-dev mailing list