[Mesa-dev] [PATCH 1/4] i965: Drop BO_ALLOC_BUSY in intel_miptree_create_for_bo().

Jason Ekstrand jason at jlekstrand.net
Tue Mar 27 01:59:55 UTC 2018


Rb

On March 26, 2018 16:52:40 Kenneth Graunke <kenneth at whitecape.org> wrote:

> intel_miptree_create_for_bo does not actually allocate a BO, so
> specifying allocation flags accomplishes nothing and is confusing.
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c 
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index c6213b21629..23cb40f3226 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -820,7 +820,7 @@ intel_miptree_create_for_bo(struct brw_context *brw,
>                         devinfo->gen >= 6 ? depth_only_format : format,
>                         0, 0, width, height, depth, 1, ISL_TILING_Y0_BIT,
>                         ISL_SURF_USAGE_DEPTH_BIT | ISL_SURF_USAGE_TEXTURE_BIT,
> -                        BO_ALLOC_BUSY, pitch, bo);
> +                        0, pitch, bo);
>       if (!mt)
>          return NULL;
>
> @@ -836,7 +836,7 @@ intel_miptree_create_for_bo(struct brw_context *brw,
>                         ISL_TILING_W_BIT,
>                         ISL_SURF_USAGE_STENCIL_BIT |
>                         ISL_SURF_USAGE_TEXTURE_BIT,
> -                        BO_ALLOC_BUSY, pitch, bo);
> +                        0, pitch, bo);
>       if (!mt)
>          return NULL;
>
> --
> 2.16.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev





More information about the mesa-dev mailing list