[Mesa-dev] [PATCH v3] mesa: readpixels add support for GL_HALF_FLOAT

[Tapani Pälli]

Thanks, I'll modify the commit message a bit and push this in.

On 03/26/2018 05:13 PM, Lin Johnson wrote:
> Ext_color_buffer_half_float is using type GL_HALF_FLOAT
> and data_type GL_FLOAT. This fix Android CTS test
> android.view.cts.PixelCopyTest
> v2: remove commtens of Ext_color_buffer_half_float.
> As Ext_color_buffer__float can use type GL_HALF_FLOAT
> 
> Reviewed-by:   Palli, Tapani <tapani.palli at intel.com>
> Signed-off-by: Lin Johnson <johnson.lin at intel.com>
> ---
>   src/mesa/main/readpix.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
> index 6ce340ddf9bb..4407f13289e2 100644
> --- a/src/mesa/main/readpix.c
> +++ b/src/mesa/main/readpix.c
> @@ -920,6 +920,8 @@ read_pixels_es3_error_check(GLenum format, GLenum type,
>      case GL_RGBA:
>         if (type == GL_FLOAT && data_type == GL_FLOAT)
>            return GL_NO_ERROR; /* EXT_color_buffer_float */
> +      if (type == GL_HALF_FLOAT && data_type == GL_FLOAT)
> +         return GL_NO_ERROR;
>         if (type == GL_UNSIGNED_BYTE && data_type == GL_UNSIGNED_NORMALIZED)
>            return GL_NO_ERROR;
>         if (internalFormat == GL_RGB10_A2 &&
>