[Mesa-dev] [PATCH 8/8] i965: Silence unused parameter warning

[Alejandro Piñeiro]

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>


On 27/03/18 04:00, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> src/mesa/drivers/dri/i965/brw_draw_upload.c: In function ‘double_types’:
> src/mesa/drivers/dri/i965/brw_draw_upload.c:225:34: warning: unused parameter ‘brw’ [-Wunused-parameter]
>  double_types(struct brw_context *brw,
>                                   ^~~
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> index 4ede33aea17..344e2f2b4ee 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
> @@ -222,9 +222,7 @@ static const GLuint byte_types_scale[5] = {
>  };
>  
>  static GLuint
> -double_types(struct brw_context *brw,
> -             int size,
> -             GLboolean doubles)
> +double_types(int size, GLboolean doubles)
>  {
>     /* From the BDW PRM, Volume 2d, page 588 (VERTEX_ELEMENT_STATE):
>      * "When SourceElementFormat is set to one of the *64*_PASSTHRU formats,
> @@ -292,7 +290,7 @@ brw_get_vertex_surface_type(struct brw_context *brw,
>        return ISL_FORMAT_R11G11B10_FLOAT;
>     } else if (glattrib->Normalized) {
>        switch (glattrib->Type) {
> -      case GL_DOUBLE: return double_types(brw, size, glattrib->Doubles);
> +      case GL_DOUBLE: return double_types(size, glattrib->Doubles);
>        case GL_FLOAT: return float_types[size];
>        case GL_HALF_FLOAT:
>        case GL_HALF_FLOAT_OES:
> @@ -371,7 +369,7 @@ brw_get_vertex_surface_type(struct brw_context *brw,
>        }
>        assert(glattrib->Format == GL_RGBA); /* sanity check */
>        switch (glattrib->Type) {
> -      case GL_DOUBLE: return double_types(brw, size, glattrib->Doubles);
> +      case GL_DOUBLE: return double_types(size, glattrib->Doubles);
>        case GL_FLOAT: return float_types[size];
>        case GL_HALF_FLOAT:
>        case GL_HALF_FLOAT_OES: