[Mesa-dev] [PATCH 3/8] util: Use util_is_power_of_two_nonzero in u_vector

[Alejandro Piñeiro]

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>


On 27/03/18 04:00, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Previously size=0, element_size=0 would have been allowed.  That
> combination can only lead to despair.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/util/u_vector.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/util/u_vector.c b/src/util/u_vector.c
> index bec6e5bbc30..15f8ed6bdad 100644
> --- a/src/util/u_vector.c
> +++ b/src/util/u_vector.c
> @@ -37,8 +37,8 @@
>  int
>  u_vector_init(struct u_vector *vector, uint32_t element_size, uint32_t size)
>  {
> -   assert(util_is_power_of_two_or_zero(size));
> -   assert(element_size < size && util_is_power_of_two_or_zero(element_size));
> +   assert(util_is_power_of_two_nonzero(size));
> +   assert(element_size < size && util_is_power_of_two_nonzero(element_size));
>  
>     vector->head = 0;
>     vector->tail = 0;