[Mesa-dev] [PATCH mesa] gles: remove entrypoint check that shouldn't be there

Dylan Baker dylan at pnwbakers.com
Wed Mar 28 17:04:54 UTC 2018


Adding Ian, he understands which symbols are and aren't supposed to be exposed
better than anyone.

Quoting Eric Engestrom (2018-03-28 07:43:01)
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
> If I understand the comment correctly, these should *not* be exposed, right?
> They aren't in any build I checked, and will cause the updated tests to fail
> if the check is left here.
> ---
>  src/mapi/es1api/ABI-check | 3 ---
>  src/mapi/es2api/ABI-check | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/src/mapi/es1api/ABI-check b/src/mapi/es1api/ABI-check
> index 11b4923dea280be2f849..d8501e5d8c5c2fdd1ca1 100755
> --- a/src/mapi/es1api/ABI-check
> +++ b/src/mapi/es1api/ABI-check
> @@ -4,7 +4,6 @@ set -eu
>  # Print defined gl.* functions not in GL ES 1.1 or in
>  # (FIXME, none of these should be part of the ABI)
>  # GL_EXT_multi_draw_arrays
> -# GL_OES_EGL_image
>  
>  # or in extensions that are part of the ES 1.1 extension pack.
>  # (see http://www.khronos.org/registry/gles/specs/1.1/opengles_spec_1_1_extension_pack.pdf)
> @@ -65,8 +64,6 @@ glDisable
>  glDisableClientState
>  glDrawArrays
>  glDrawElements
> -glEGLImageTargetRenderbufferStorageOES
> -glEGLImageTargetTexture2DOES
>  glEnable
>  glEnableClientState
>  glFinish
> diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api/ABI-check
> index a04b03d7d6006ad7f2cc..2d92d1c0028697f1439e 100755
> --- a/src/mapi/es2api/ABI-check
> +++ b/src/mapi/es2api/ABI-check
> @@ -4,7 +4,6 @@ set -eu
>  # Print defined gl.* functions not in GL ES 3.0 or in
>  # (FIXME, none of these should be part of the ABI)
>  # GL_EXT_multi_draw_arrays
> -# GL_OES_EGL_image
>  
>  case "$(uname)" in
>  Darwin)
> @@ -118,8 +117,6 @@ glDrawElementsInstanced
>  glDrawElementsInstancedBaseVertex
>  glDrawRangeElements
>  glDrawRangeElementsBaseVertex
> -glEGLImageTargetRenderbufferStorageOES
> -glEGLImageTargetTexture2DOES
>  glEnable
>  glEnableVertexAttribArray
>  glEnablei
> -- 
> Cheers,
>   Eric
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180328/0c1611a5/attachment-0001.sig>


More information about the mesa-dev mailing list