[Mesa-dev] [PATCH] vbo: MaxVertexAttribStride is not always set

[Jakob Bornecrantz]

On 2018-03-30 16:49, Mathias Fröhlich wrote:
> On Friday, 30 March 2018 17:38:39 CEST Jakob Bornecrantz wrote:
>> This assert is hit on hardware which does expose GL 4.4 or GLES 3.1.
> 
> Uff - sorry!
> 
> Reviewed-by: Mathias Fröhlich <mathias.froehlich at web.de>

Thanks, tho that should be "which does NOT expose" but you got the gist.

Cheers, Jakob.

> 
> Mathias
> 
>>
>> Signed-off-by: Jakob Bornecrantz <jakob at collabora.com>
>> ---
>>   src/mesa/vbo/vbo_save_api.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c
>> index a367a569c8..71304ede49 100644
>> --- a/src/mesa/vbo/vbo_save_api.c
>> +++ b/src/mesa/vbo/vbo_save_api.c
>> @@ -492,8 +492,13 @@ update_vao(struct gl_context *ctx,
>>      _mesa_reference_vao(ctx, vao, NULL);
>>      *vao = _mesa_new_vao(ctx, ~((GLuint)0));
>>   
>> +   /*
>> +    * assert(stride <= ctx->Const.MaxVertexAttribStride);
>> +    * MaxVertexAttribStride is not set for drivers that does not
>> +    * expose GL 44 or GLES 31.
>> +    */
>> +
>>      /* Bind the buffer object at binding point 0 */
>> -   assert(stride <= ctx->Const.MaxVertexAttribStride);
>>      _mesa_bind_vertex_buffer(ctx, *vao, 0, bo, buffer_offset, stride,
> false);
>>   
>>      /* Retrieve the mapping from VBO_ATTRIB to VERT_ATTRIB space
>>
> 
> 
> 
>