[Mesa-dev] [PATCH] gallium/pipebuffer: fix bracket location

Timothy Arceri tarceri at itsqueeze.com
Sat Mar 31 23:32:28 UTC 2018


Without this the return value will never get set to -1. This
was first added in 49866c8f3457 and copied in 2b396eeed983.

Fixes: 2b396eeed983 "gallium/pb_cache: add a copy of cache bufmgr independent of pb_manager"

Cc: Marek Olšák <maraeo at gmail.com>
Cc: Dave Airlie <airlied at gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102342
---
 src/gallium/auxiliary/pipebuffer/pb_cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/pipebuffer/pb_cache.c b/src/gallium/auxiliary/pipebuffer/pb_cache.c
index 0aaedbfae4c..2b9ad498045 100644
--- a/src/gallium/auxiliary/pipebuffer/pb_cache.c
+++ b/src/gallium/auxiliary/pipebuffer/pb_cache.c
@@ -169,7 +169,7 @@ pb_cache_reclaim_buffer(struct pb_cache *mgr, pb_size size,
       cur_entry = LIST_ENTRY(struct pb_cache_entry, cur, head);
 
       if (!entry && (ret = pb_cache_is_buffer_compat(cur_entry, size,
-                                                     alignment, usage) > 0))
+                                                     alignment, usage)) > 0)
          entry = cur_entry;
       else if (os_time_timeout(cur_entry->start, cur_entry->end, now))
          destroy_buffer_locked(cur_entry);
-- 
2.14.3



More information about the mesa-dev mailing list